Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] paths with leading ./ no longer matching #144

Closed
1 task done
wraithgar opened this issue Apr 10, 2024 · 1 comment · Fixed by #145
Closed
1 task done

[BUG] paths with leading ./ no longer matching #144

wraithgar opened this issue Apr 10, 2024 · 1 comment · Fixed by #145
Assignees
@wraithgar
Labels
Needs Triage needs an initial review

Comments

@wraithgar
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

If pkg.workspaces is set to ['./packages/*'] and I have workspaces in that directory, I still get an empty result set.

Expected Behavior

I should get all of the workspaces in ./packages/*

Steps To Reproduce

@npmcli/map-workspaces@3.0.5

Environment

Present in at least OSX
@wraithgar wraithgar added the Needs Triage needs an initial review label Apr 10, 2024
@wraithgar wraithgar self-assigned this Apr 10, 2024
@wraithgar
Copy link
Member Author

Introduce in https://github.com/npm/map-workspaces/pull/143/files#diff-92bbac9a308cd5fcf9db165841f2d90ce981baddcb2b1e26cfff170929af3bd1R135

The call to minimatch doesn't exactly line up w/ how glob worked.

This was referenced Apr 10, 2024
Merged
Merged
wraithgar added a commit that referenced this issue Apr 10, 2024
@wraithgar
fix: allow for workspace patterns to start with ./ (#145)
e2a803b 
Closes #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wraithgar wraithgar

Labels
Needs Triage needs an initial review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow for workspace patterns to start with ./ npm/map-workspaces
1 participant
@wraithgar