Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not setup the response timeout if the stream has already ended #53

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix: do not setup the response timeout if the stream has already ended #53

merged 1 commit into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. fix: do not setup the response timeout if the stream has already ended 

    this change ensures we will not trigger a timeout caused by a slow
stream pipeline if the stream has already ended. this subtly shifts the
meaning of the timeout from "the response has been fully consumed" to
"the socket behind the response has finished" which i feel maintains the
spirit of the timeout while also not needlessly throwing errors when
we're not using the socket any more.
    @nlf
    nlf committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    25b6b51 View commit details
    Browse the repository at this point in the history