Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] diff is inconsistent in comparing prerelease to later versions #561

Closed
1 task done
pgsandstrom opened this issue May 26, 2023 · 0 comments · Fixed by #566
Closed
1 task done

[BUG] diff is inconsistent in comparing prerelease to later versions #561

pgsandstrom opened this issue May 26, 2023 · 0 comments · Fixed by #566
Labels
Bug thing that needs fixing Priority 1 high priority issue

Comments

@pgsandstrom
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

This code:

    console.log(diff('2.0.0-alpha.1', '2.0.0'))
    console.log(diff('2.0.0-alpha.1', '2.1.1'))

Results in "major" and "minor".

Expected Behavior

The code should result in the output "major", "major".

Steps To Reproduce

Just run the code with semver v7.5.1. The bug seems to have appeared in 7.4.0.

Environment

  • npm: 8.18.0
  • Node: v18.8.0
  • OS: Windows 11
  • platform: node
@pgsandstrom pgsandstrom added Bug thing that needs fixing Needs Triage needs an initial review labels May 26, 2023
@lukekarrys lukekarrys mentioned this issue Jun 15, 2023
Merged
lukekarrys added a commit that referenced this issue Jun 15, 2023
@lukekarrys
fix: diff when detecting major change from prerelease
56c8411 
Fixes #561
lukekarrys added a commit that referenced this issue Jun 15, 2023
@lukekarrys
fix: diff when detecting major change from prerelease
e5856da 
Fixes #561
@lukekarrys lukekarrys added Priority 1 high priority issue and removed Needs Triage needs an initial review labels Jun 15, 2023
lukekarrys added a commit that referenced this issue Jun 15, 2023
@lukekarrys
fix: diff when detecting major change from prerelease (#566)
58c791f 
Fixes #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug thing that needs fixing Priority 1 high priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: diff when detecting major change from prerelease npm/node-semver
2 participants
@lukekarrys @pgsandstrom