Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

> ### Is there an existing issue for this? #675

Closed
Gemk83 opened this issue Jan 10, 2024 · 0 comments
Closed

> ### Is there an existing issue for this? #675

Gemk83 opened this issue Jan 10, 2024 · 0 comments
Labels

Comments

@Gemk83
Copy link

Gemk83 commented Jan 10, 2024

          > ### Is there an existing issue for this?
  • I have searched the existing issues

Current Behavior

valid("1.0.0rc1")

returns true, but

["1.0.0", "1.0.0rc1"].sort(compare)

throws

TypeError: Invalid Version: 1.0.0rc1

Expected Behavior

valid("1.0.0rc1") returns false

Steps To Reproduce

See current/expected behaviour.

Environment

  • npm:
  • Node: 18
  • OS: osx
  • platform: arm64

Originally posted by @Gemk83 in #672 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants