Add 'standard' to npm test and address issues #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
reviewed
Oct 12, 2018
package.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "description": "The semantic version parser used by npm.", | |||
| "main": "semver.js", | |||
| "scripts": { | |||
| "test": "standard && tap test/*.js --cov -J" | |||
| "test": "standard bin/semver *.js **/*.js && tap test/*.js --cov -J" | |||
There was a problem hiding this comment.
Can you move the standard command invocation to a posttest script instead?
I prefer to run tests before linting, so that it's less annoying when building new features or fixing bugs, and the && is a sh-ism that doesn't work on Windows.
There was a problem hiding this comment.
Makes sense to me, working on it now.
|
Rebased and landed on master. Thanks! |
stabbylambda
pushed a commit
to stabbylambda/node-semver
that referenced
this pull request
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #146