Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the fancy preload logic in index.js #311

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Remove the fancy preload logic in index.js #311

merged 1 commit into from
Jan 31, 2020

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Jan 22, 2020

This is causing some friction for webpack users, and doesn't seem to be
worth the trouble from a performance point of view in npm/cli.

Ditch it.

Fix #306

@isaacs isaacs mentioned this pull request Jan 22, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f100da6 on isaacs/remove-lazy-require into 70d9fb3 on master.

@coveralls
Copy link

coveralls commented Jan 22, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 70593f7 on isaacs/remove-lazy-require into 70d9fb3 on master.

@darcyclarke darcyclarke added this to the OSS - Sprint 3 milestone Jan 28, 2020
mikemimik
mikemimik approved these changes Jan 30, 2020
View reviewed changes
Copy link

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Does any documentation need to change with the landing of this pull-request?

@isaacs
Copy link
Contributor Author

isaacs commented Jan 31, 2020

Does any documentation need to change with the landing of this pull-request?

Good call, there was one weird nit. Fixed and force-pushed. I'll pull this and publish now.

@isaacs
Remove the fancy preload logic in index.js
70593f7 
This is causing some friction for webpack users, and doesn't seem to  be
worth the trouble from a performance point of view in npm/cli.

Ditch it.

Fix #306
@isaacs isaacs merged commit 70593f7 into master Jan 31, 2020
@soda-x soda-x mentioned this pull request Mar 1, 2021
Open
@lukekarrys lukekarrys deleted the isaacs/remove-lazy-require branch February 24, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemimik mikemimik mikemimik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OSS - Sprint 3
Development

Successfully merging this pull request may close these issues.

[BUG] Upgrading to version 7 causes webpack error
4 participants
@isaacs @coveralls @mikemimik @darcyclarke