Removed octal literals #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need this for babel es6 support please. |
Closed
|
Working on node 7.4.0, Ubuntu 16.10 |
|
Done on v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in strict mode, Node (v6.6.0) throws a fit over the fact that the code uses 'octal literals' (i.e
0666and07777777, basically anything in base 8). The proper way to handle this is to useparseInt('octal', 8)which then converts it to the correct number, instead of just writing them out in the code. This pull request has changed every appearance of octals to use the correct method.Tested successfully on v6.6.0, Windows x64 (can't see why it shouldn't work everywhere though but don't mind doing more testing if required). If people want a working version of this library and this PR hasn't been merged you can find the fork at https://github.com/nickdbush/node-tar