New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative paths stopped working #33
Comments
Well that's weird, because 1.2.5 was supposed to fix handling of relative paths. I'll dig in soon. |
Feel free to send a PR (or just paste an example) with a failing test case. |
@satazor Can you try |
@isaacs when I arrive home I will try it out! |
@isaacs I confirm that |
@satazor \o/ Awesome. I'll add a test and try to get this shipped soon. |
gj |
Not sure if this is related issue, but I see some inconsistency in how ...Projects/OSS/sort-staged-example master ✘ ✹ ✚ $ which ./front/postcss/sort
./front/postcss/sort
...Projects/OSS/sort-staged-example master ✘ ✹ ✚ $ node bin/which ./front/postcss/sort
module.js:457
throw err;
^
Error: Cannot find module '/Users/okonet/Projects/OSS/sort-staged-example/bin/which'
at Function.Module._resolveFilename (module.js:455:15)
at Function.Module._load (module.js:403:25)
at Module.runMain (module.js:590:10)
at run (bootstrap_node.js:394:7)
at startup (bootstrap_node.js:149:9)
at bootstrap_node.js:509:3 |
@okonet That's not a problem with this code, it's a problem when the way you're trying to invoke it. Observe:
|
I got a bug report in
cross-spawn-async
related to relative paths not working correctly. After investigation,which
changed handling of relative paths in1.2.5
. The same test when usingwhich@1.2.4
passes. As a workaround, if I dopath.resolve
before callingwhich
it works correctly.I will add a test case if necessary.
The text was updated successfully, but these errors were encountered: