Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check lower case extensions in windows #100

Merged
merged 1 commit into from May 1, 2023
Merged

fix: check lower case extensions in windows #100

merged 1 commit into from May 1, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented May 1, 2023 •
edited

Closes #57

@wraithgar wraithgar requested a review from a team as a code owner May 1, 2023 16:14
@wraithgar wraithgar requested a review from nlf May 1, 2023 16:14
@wraithgar
Copy link
Member Author

We may have to cast to lower case since %PATHEXT% also exists

@wraithgar
Copy link
Member Author

It looks like windows convention is still to set PATHEXT to all upper case so this is the best option, rather than trying to cast both directions.

@wraithgar wraithgar merged commit c3a543e into main May 1, 2023
23 checks passed
@wraithgar wraithgar deleted the gar/lower-case-ext branch May 1, 2023 17:21
@github-actions github-actions bot mentioned this pull request May 1, 2023
Merged
@wraithgar wraithgar mentioned this pull request May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't find executables in case-sensitive directory on Windows
2 participants
@wraithgar @nlf