New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a new list
reporter
#10
Conversation
… less than a page. Also lets you do `| grep critical` (for example)
@luislobo I haven't had a chance to test this out, do you happen to have a screenshot of the output (I swear I've seen one someplace and thought it was here but now it's not so I'm confused) :) |
yeah sure! It was on a tweet in response to @zkat tweet about audit. |
@zkat suggested changing it as
|
@zkat may I ask why it was closed? |
oh. I guess this happened because of renaming the default branch to |
fixed :) |
Awesome 😍 |
I'm gonna /cc @iarna and @evilpacket on this to get their perspective on the |
My initial concern about the screenshot above is terminal width requirements and trying to keep output , but I'm pro a greppable report, which could probably meet both requirements with a |
I could make a I'm fine with getting rid of the One question though, it's a funcional one. Can you check the PR, there is a TODO/TOCHECK here: https://github.com/npm/npm-audit-report/pull/10/files#diff-a06ff6c66ce9794c6a36389e432a5266R117 |
…no titles, no footer. Uses colors
npm cli side, parseable output should never have colors (it is solely intended for consumption by tooling and should not require additional flags). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this can land tests will need to be passing (currently this is failing our linter)
Replaced this PR with #21, closing this one. New one has |
Adds a new
list
reporter, with a more streamlined output.Lets you do
| grep critical
(for example), as it prints everything in one line.Please check the TODO comment to see if it's valid
I also have a change for
npm
that I'm about to send after this one, so thatnpm audit
has a--list
parameterAdresses #7