detail: Switch to inverting the cmd to run instead of quoting #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
change-code-presentation
branch
from
d5518f4
to
b9ce234
Compare
The idea here is that this way double clicking the command to run will never pick up backticks. It's also substantially more visible. I swapped from `ansicolors` to my own `console-control-strings` for this to get the invert codes.
iarna
force-pushed
the
change-code-presentation
branch
from
b9ce234
to
d78470e
Compare
I… didn't notice this was already imported when I switched to console-control-strings. It woulda done the job… but it's not actually used anyway.
iarna
commented
Apr 29, 2018
| @@ -92,7 +92,7 @@ const report = function (data, options) { | |||
| if (action.action === 'update' || action.action === 'install') { | |||
| const recommendation = getRecommendation(action, config) | |||
| const label = action.resolves.length === 1 ? 'vulnerability' : 'vulnerabilities' | |||
| log(`\n\n# Run \`${Utils.color(recommendation.cmd, 'red', config.withColor)}\` to resolve ${action.resolves.length} ${label}`) | |||
| log(`\n\n# Run ${Utils.color(' ' + recommendation.cmd + ' ', 'inverse', config.withColor)} to resolve ${action.resolves.length} ${label}`) | |||
There was a problem hiding this comment.
When this was red, it was Utils.color(…, ['red', 'inverse'], configWithColor). (The console-control-strings color function can combine multiple color codes efficiently.)
Worth noting here is the added spacing around the command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that this way double clicking the command to run will never pick up backticks. It's also substantially more visible.
I swapped from
ansicolorsto my ownconsole-control-stringsfor this to get the invert codes.I ah, also ended up rewriting
lib/utils.jsl a bit. 😅🙏Anyway, this is what it looks like (in Terminal and iTerm2):