feat: remove dependency on arborist, require tree to be passed in #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the arborist tree must now be provided in the options and will not be generated for you. the npm-packlist bin has also been removed.
nlf
force-pushed
the
nlf/provide-tree
branch
from
5d61936
to
d20b5da
Compare
lukekarrys
approved these changes
Sep 23, 2022
ljharb
reviewed
Sep 23, 2022
This also uses `tree.path` as the fallback instead of `process.cwd()`. Arborist defaults to `cwd` as well so there is no functional difference. This also refactors away some dead code now that tree is required. BREAKING CHANGE: `tree` is now the first parameter
ljharb
reviewed
Sep 24, 2022
| } | ||
|
|
||
| super(options) | ||
| this.isPackage = options.isPackage | ||
| this.seen = options.seen || new Set() | ||
| this.tree = options.tree // no default, we'll load the tree later if we need to | ||
| this.tree = tree |
There was a problem hiding this comment.
i think this should have some kind of runtime check, so that if something not-tree-like is passed, it eagerly throws an exception.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the arborist tree must now be provided in the options and will not be generated for you. the npm-packlist bin has also been removed.