fix: avoid modifying singleton variable #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Dec 8, 2023
| @@ -9,7 +9,7 @@ const packlist = require('../') | |||
| const pkg = t.testdir({ | |||
| 'package.json': JSON.stringify({ | |||
| files: [ | |||
| '**/*.js', | |||
There was a problem hiding this comment.
What code path is this change testing?
There was a problem hiding this comment.
The same code path. This glob wasn't sufficient to trigger the test case, as it implicitly excludes the non-root readme/license files already.
wraithgar
changed the title
|
🤦 good catch. Things are going to slow down this month so it may be a little while till we can do a full review on this. Probably January. |
wraithgar
approved these changes
Jan 3, 2024
Merged
wraithgar
pushed a commit
that referenced
this pull request
Jan 8, 2024
🤖 I have created a release *beep* *boop* --- ## [8.0.2](v8.0.1...v8.0.2) (2024-01-03) ### Bug Fixes * [`728d68a`](728d68a) [#214](#214) handling of directory glob (#214) (@mohd-akram) * [`837af58`](837af58) [#210](#210) avoid modifying singleton variable (#210) (@mohd-akram) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.