feat: throw forbidden error when package is blocked by security policy #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
This PR introduces a new error in the case that a forbidden package was requested and blocked by the security proxy. If no manifest was found under the
versions
object, then a check is done to verify if the package is forbidden under therestrictedVersions
object. If it is, a new error code is thrownE403
and the admin custom message will be shown on the CLI like:If no policy restrictions are found on the packument then the behavior will continue as is right now and throw a
ETARGET
error.🔗 References
RFC: https://npmjs.slab.com/posts/proposed-package-filtering-messaging-on-the-cli-kejlhyow
🔍 Testing
Automated testing
✅ This change has unit test coverage
This PR depends on: npm/cli#234