This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
add data and response into request #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
suggested changes
Mar 7, 2017
There was a problem hiding this comment.
Hey @watilde -- do you mind writing a quick test to https://github.com/npm/npm-registry-client/blob/master/test/ping.js to make sure we're returning everything even on error?
watilde
force-pushed
the
feature/status
branch
3 times, most recently
from
104e031
to
761aef9
Compare
|
@zkat Hello! I just added a test for it now :) |
|
@watilde thanks! Could you make sure |
|
Ah you're right, that should be checked in tests :) I've added the following two lines for it! + t.same(data, JSON.stringify(wanted))
+ t.same(res.body.toString(), JSON.stringify(wanted)) |
|
Released as |
|
Great! Arigato<3 |
|
いいえいいえ。こちらこそ、ワチくん。＾＿＿＿＾ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from npm/npm#15306. To get a statusCode in
npm/lib/ping.js, we need to pass them even error exists.