Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Commit

Permalink
vdu: Require shasums on new uploads
Browse files Browse the repository at this point in the history
  • Loading branch information
isaacs committed Feb 16, 2013
1 parent 9f8a4f0 commit 221c45d
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions registry/validate_doc_update.js
Expand Up @@ -168,6 +168,19 @@ module.exports = function (doc, oldDoc, user, dbCtx) {
assert(versions[latest], "dist-tags.latest must be valid version")
}

// the 'latest' version must have a dist and shasum
// I'd like to also require this of all past versions, but that
// means going back and cleaning up about 2000 old package versions,
// or else *new* versions of those packages can't be published.
// Until that time, do this instead:
var version = versions[latest]
if (!version.dist)
assert(false, "no dist object in " + latest + " version")
if (!verions.dist.tarball)

This comment has been minimized.

Copy link
@falsecz

falsecz Feb 16, 2013

typo verions

assert(false, "no tarball in " + latest + " version")
if (!verions.dist.shasum)

This comment has been minimized.

Copy link
@falsecz

falsecz Feb 16, 2013

typo verions

assert(false, "no shasum in " + latest + " version")

for (var v in doc["dist-tags"]) {
var ver = doc["dist-tags"][v]
assert(semver.valid(ver),
Expand Down

0 comments on commit 221c45d

Please sign in to comment.