[BUG] 30s default timeout is too small #26
Comments
isaacs
added a commit
that referenced
this issue
Apr 23, 2020
Re: #26 Re: npm/cli#1151 The documented default timeout of 30s was not being set in v4, so we "fixed the glitch" in v4.0.3, causing problems for people trying to download large packages. There's no npm v6 way to specify what timeout to use, so not having a timeout at all seems like a reasonable default for the v4 line, at least. Let's roll back that change, and document it. (Arguably, fixing this bug was a breaking change, and we ought to roll it back.) This effectively reverts 69c2977, with documentation of the effective behavior before the change.
isaacs
added a commit
that referenced
this issue
Apr 23, 2020
Re: #26 Re: npm/cli#1151 The previous default of 30s was too small for lots of users, causing problems when they attempt to download large objects from the npm registry. Bump up the default timeout to 5m. TODO: add a `--fetch-timeout` option on the CLI to explicitly set `timeout` in the npm.flatOptions object passed to all dependencies.
This was referenced Apr 23, 2020
|
sounds good to me 👍 |
isaacs
added a commit
that referenced
this issue
Apr 28, 2020
Re: #26 Re: npm/cli#1151 The documented default timeout of 30s was not being set in v4, so we "fixed the glitch" in v4.0.3, causing problems for people trying to download large packages. There's no npm v6 way to specify what timeout to use, so not having a timeout at all seems like a reasonable default for the v4 line, at least. Let's roll back that change, and document it. (Arguably, fixing this bug was a breaking change, and we ought to roll it back.) This effectively reverts 69c2977, with documentation of the effective behavior before the change. PR-URL: #27 Credit: @isaacs Close: #27 Reviewed-by: @isaacs
|
Fixed by #27 |
isaacs
added a commit
that referenced
this issue
Apr 28, 2020
Re: #26 Re: npm/cli#1151 The previous default of 30s was too small for lots of users, causing problems when they attempt to download large objects from the npm registry. Bump up the default timeout to 5m. TODO: add a `--fetch-timeout` option on the CLI to explicitly set `timeout` in the npm.flatOptions object passed to all dependencies. PR-URL: #28 Credit: @isaacs Close: #28 Reviewed-by: @isaacs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What / Why
See npm/cli#1151
The documented default timeout of 30s was not being set in v4, so we "fixed the glitch" in nrf 4.0.3, causing problems for people.
There's no npm v6 way to specify what timeout to use, so not having a timeout at all seems like a reasonable default for the v4 line, at least. Let's roll back that change, and document it. (Arguably, fixing this bug was a breaking change, and we ought to roll it back.)
For latest/npm v7, it seems like 30s is way too small. We should add a
--fetch-timeoutconfig on the cli, which defaults to 3000 (5m) or so, and also use that as the default here.The text was updated successfully, but these errors were encountered: