Allow multiple requests on one route #14
Conversation
|
review? @domenic? |
|
Why would this not always be set to Infinity? Are there parts of the non-mock npm registry that only allow you to access them once? |
|
It was limited to one request before, when it was not using https://github.com/mmalecki/hock/blob/master/lib/request.js#L43 But maybe we should set the limit to Infinity, and if people need smaller limit, they can set it with the options. I would raise the version to 1.0.0 then, what do you think? |
|
That would make sense to me, but you know more about what would be more useful for npm-registry-mock in relation to the npm tests, so I am not sure. |
Some tests need multiple requests and using plugins is not that handy if you want to use preconfigured routes. If you do not provide an explicit option for that, it will set the maxRequests to Infinity. Before there was a `many` method in hock it had a hard limit of 1. Additionally, options are now passed 1:1 to hock, if they are an object
|
I slept a night over this: It is more convenient and helpful, also but not only for first-time-users, to allow infinite requests. Even after writing alot of tests I never had the problem of an unknown, additional requests that was caught by the limit. But I often had just problems with the limit as I needed two requests for a package. |
|
@domenic updated! |
|
LGTM aside from documentation nit. Fix that and merge it :) |
Some tests need multiple requests and using plugins is not that
handy if you want to use preconfigured routes.
If you do not provide an explicit option for that, it will
set the maxRequests to 1 - which is the current default.
Additionally, options are now passed 1:1 to hock, if they are an
object