Skip to content
This repository has been archived by the owner on Dec 10, 2022. It is now read-only.

Add optimist #6

Merged
merged 3 commits into from Dec 26, 2013
Merged

Add optimist #6

merged 3 commits into from Dec 26, 2013

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Dec 26, 2013

Adds optimist (and wordwrap, minimist) to the fixtures, and also adds a add-fixture.sh script to make it easier for people to add fixtures in the future.

Relevant to isaacs/npm#4368

@robertkowalski
Copy link
Contributor

Wow, awesome X-Mas present!

The shell script is not working currently, I debugged the case a little bit:

curl  https://registry.npmjs.org/foo-private > fixtures/foo-private.json
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: Invalid certificate chain
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.

I am not sure if this is a temporary issue regarding the registry.

@isaacs
Copy link
Contributor Author

isaacs commented Dec 26, 2013

Ah, right, sorry. Thats because you're still pointing at the pre-CDN registry, which has a certificate that curl and browsers don't understand. It should probably just use the http:// url anyway. I'll fix up in one sec.

@isaacs
Copy link
Contributor Author

isaacs commented Dec 26, 2013

Fixed up. I didn't notice it because I've pointed the registry at the new servers in my /etc/hosts file.

@robertkowalski robertkowalski merged commit c32f843 into npm:master Dec 26, 2013
@robertkowalski
Copy link
Contributor

thanks. published the new version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants