Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Commit

Permalink
node-gyp-bin: fix custom node-gyp env var quoting
Browse files Browse the repository at this point in the history
npm sets node_config_node_gyp without quotes, so its usage should be
quoted. Indeed, it is a better practice to define environment variables
that contain paths without quotes and quote their usage.

PR-URL: #11158
Credit: @orangemocha
Reviewed-By: @othiym23
  • Loading branch information
orangemocha authored and iarna committed Jan 21, 2016
1 parent b463e34 commit 00720db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/node-gyp-bin/node-gyp.cmd
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
if not defined npm_config_node_gyp (
node "%~dp0\..\..\node_modules\node-gyp\bin\node-gyp.js" %*
) else (
node %npm_config_node_gyp% %*
node "%npm_config_node_gyp%" %*
)

0 comments on commit 00720db

Please sign in to comment.