This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
install/deps: Stop weird call-back-to-self in resolveWithNewModule
We were doing a weird thing where we used a package.json field _installable_ to check to see if we'd checked for platform compatibility, and if not did so. But this was the only place that was ever done so there was no reason to implement it in such an obfuscated manner. Instead it now just directly checks and then records that its done so on the node object with `knownInstallable`. This is useful to know because modules expanded via shrinkwrap don't go through this– `inflateShrinkwrap` does not currently have any rollback semantics and so checking this sort of thing there is unhelpful. PR-URL: #13692 Credit: @iarna Reviewed-By: @zkat
- Loading branch information
Showing
1 changed file
with
35 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters