completion: enable on Windows in git bash

npm completion used to be always blocked on Windows, but it works just fine on Git Bash. Fixes: #10156 Credit: @jakub-g Reviewed-By: @othiym23 PR-URL: #10156
npm · Nov 25, 2015 · 09498e4 · 09498e4
1 parent 4659f1c
commit 09498e4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/completion.js b/lib/completion.js
@@ -45,8 +45,8 @@ completion.completion = function (opts, cb) {
 }
 
 function completion (args, cb) {
-  if (process.platform === 'win32') {
-    var e = new Error('npm completion not supported on windows')
+  if (process.platform === 'win32' && !(/^MINGW(32|64)$/.test(process.env.MSYSTEM))) {
+    var e = new Error('npm completion supported only in MINGW / Git bash on Windows')
     e.code = 'ENOTSUP'
     e.errno = require('constants').ENOTSUP
     return cb(e)