better errors for malformed .npmrc properties

lib/config/core.js

@@ -36,7 +36,7 @@ var myGid = process.env.SUDO_GID !== undefined
 
 var loading = false
 var loadCbs = []
-function load (cli_, builtin_, cb_) {
+function load () {
   var cli, builtin, cb
   for (var i = 0; i < arguments.length; i++)
     switch (typeof arguments[i]) {
@@ -92,6 +92,7 @@ function load (cli_, builtin_, cb_) {
   rc.on("load", function () {
     load_(builtin, rc, cli, cb)
   })
+  rc.on("error", cb)
 }
 
 function load_(builtin, rc, cli, cb) {
@@ -261,7 +262,7 @@ Conf.prototype.save = function (where, cb) {
 
   var mode = where === "user" ? "0600" : "0666"
   if (!data.trim()) {
-    fs.unlink(target.path, function (er) {
+    fs.unlink(target.path, function () {
       // ignore the possible error (e.g. the file doesn't exist)
       done(null)
     })
@@ -321,9 +322,15 @@ Conf.prototype.parse = function (content, file) {
 }
 
 Conf.prototype.add = function (data, marker) {
-  Object.keys(data).forEach(function (k) {
-    data[k] = parseField(data[k], k)
-  })
+  try {
+    Object.keys(data).forEach(function (k) {
+      data[k] = parseField(data[k], k)
+    })
+  }
+  catch (e) {
+    this.emit("error", e)
+    return this
+  }
   return CC.prototype.add.call(this, data, marker)
 }
 
@@ -360,8 +367,14 @@ function parseField (f, k) {
 
   f = (""+f).trim()
 
-  if (f.match(/^".*"$/))
-    f = JSON.parse(f)
+  if (f.match(/^".*"$/)) {
+    try {
+      f = JSON.parse(f)
+    }
+    catch (e) {
+      throw new Error("Failed parsing JSON config key " + k + ": " + f)
+    }
+  }
 
   if (isBool && !isString && f === "")
     return true

test/fixtures/config/malformed

@@ -0,0 +1 @@
+email = """

test/tap/00-config-setup.js

@@ -3,6 +3,7 @@ var userconfigSrc = path.resolve(__dirname, "..", "fixtures", "config", "usercon
 exports.userconfig = userconfigSrc + "-with-gc"
 exports.globalconfig = path.resolve(__dirname, "..", "fixtures", "config", "globalconfig")
 exports.builtin = path.resolve(__dirname, "..", "fixtures", "config", "builtin")
+exports.malformed = path.resolve(__dirname, "..", "fixtures", "config", "malformed")
 exports.ucData =
   { globalconfig: exports.globalconfig,
     email: "i@izs.me",

test/tap/config-malformed.js

@@ -0,0 +1,14 @@
+var test = require('tap').test
+
+var npmconf = require("../../lib/config/core.js")
+var common = require("./00-config-setup.js")
+
+test('with malformed', function (t) {
+  npmconf.load({}, common.malformed, function (er, conf) {
+    t.ok(er, 'Expected parse error')
+    if (!(er && /Failed parsing JSON config key email/.test(er.message))) {
+      throw er
+    }
+    t.end()
+  })
+})