Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Commit

Permalink
bump nopt and npmconf
Browse files Browse the repository at this point in the history
Fixes #5591

The root cause here is that a change from 022 (a number in octal literal
format) to '022' (a string) caused the string to later be interpreted as
a decimal number, making for some wacky umask values.

Solution is multipart.

First, use the actual process.umask() value from the user's environment.
This is almost certainly what they want anyway.

Second, validate all default values just like we do with user- supplied
values, rather than trusting them to never be wrong.  This would've
found the problem much sooner, while in dev.

This second part requires that we allow a value of null for 'path' type
args, allow 'undefined' for the 'local-address' config, and avoid
looking up a cafile of 'null', all of which are good hygenic things to
add defense-in-depth anyway.
  • Loading branch information
isaacs committed Jul 1, 2014
1 parent 6e6aca8 commit bea190c
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 43 deletions.
2 changes: 2 additions & 0 deletions node_modules/nopt/lib/nopt.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions node_modules/nopt/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 15 additions & 11 deletions node_modules/npmconf/config-defs.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions node_modules/npmconf/lib/load-cafile.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions node_modules/npmconf/npmconf.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 8 additions & 26 deletions node_modules/npmconf/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -58,12 +58,12 @@
"minimatch": "~0.3.0",
"mkdirp": "~0.3.5",
"node-gyp": "~0.13.0",
"nopt": "~3.0.0",
"nopt": "~3.0.1",
"npm-cache-filename": "~1.0.1",
"npm-install-checks": "~1.0.2",
"npm-registry-client": "~2.0.2",
"npm-user-validate": "~0.1.0",
"npmconf": "~1.1.2",
"npmconf": "~1.1.4",
"npmlog": "~0.1.1",
"once": "~1.3.0",
"opener": "~1.3.0",
Expand Down

0 comments on commit bea190c

Please sign in to comment.