Prune should not remove bundleDependencies.

[michaelgilley]

As is, npm prune will remove bundled dependencies. This issue can be fixed by adding a check for bundleDependencies in read-installed.js (although I'm unaware if this will create other side effects).

[michaelgilley]

This only occurs when bundledDependencies are not specified as dependencies. (Maybe specify this in the docs?

[rlidwka]

Why did you close it?

I think it is a bug, bundled deps should not be removed because they are used when packing.

[michaelgilley]

Bundled deps should also be listed in dependencies or devDependencies. This becomes an issue only when they aren't. 

Although it should be understood that a bundled dependency is a dependency by default. So this could be an issue.

On Sat, Feb 1, 2014 at 1:30 AM, Alex Kocharin notifications@github.com
wrote:

Why did you close it?

I think it is a bug, bundled deps should not be removed because they are used when packing.

Reply to this email directly or view it on GitHub:
#4573 (comment)

[rlidwka]

Bundled deps should also be listed in dependencies or devDependencies.

Why is that? I can add a private package that's not installable from anywhere, and use it as bundledDependency just as well.

[michaelgilley]

For now, if you just list the package in one of the dependency hashes also everything will run as expected.

However, it is a legitimate question why bundleDependencies are not treated as their own kind of dependency.

I'm reopening this for official comment.

[busches]

@othiym23 is the official comment that this is a bug then? :) @michaelgilley makes a good point that if the dependency was listed in dependencies or devDependencies then npm prune would not remove them.

[npm-robot]

We're closing this issue as it has gone thirty days without activity. In our experience if an issue has gone thirty days without any activity then it's unlikely to be addressed. In the case of bug reports, often the underlying issue will be addressed but finding related issues is quite difficult and often incomplete.

If this was a bug report and it is still relevant then we encourage you to open it again as a new issue. If this was a feature request then you should feel free to open it again, or even better open a PR.

For more information about our new issue aging policies and why we've instituted them please see our blog post.