Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Load metadata for arguments PRIOR to integrating them into the ideal tree #8608

Closed
iarna opened this issue Jun 19, 2015 · 1 comment
Closed
Milestone

Comments

@iarna
Copy link
Contributor

iarna commented Jun 19, 2015

In fact, we should load these before even loading the current tree. This let's us error AS SOON AS POSSIBLE when the user has typoed a module name / url to install.

Further, knowing the actual module name to be installed let's us be clever on global installs and eliminate anything not named from the currentTree prior to even cloning it. This is safe with global installs because globals flattened to the module being installed, not to the global node_modules folder, and as such aren't allowed to interact

It wouldn't be implausible to just call read-package-tree once for each of the effected globals, saving ourselves from even having to readdir your global node_modules.

@iarna iarna modified the milestones: multi-stage install, post-npm3 Jun 19, 2015
@iarna iarna modified the milestones: 3.1.0, 3.x Jun 26, 2015
@iarna
Copy link
Contributor Author

iarna commented Jul 10, 2015

Fixed in v3.1.1

(@aredridel \o/)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant