Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

multi-stage: npm marks third party dependency as extraneous and then fails on npm ls #8660

Closed
mantoni opened this issue Jun 24, 2015 · 5 comments
Labels
Milestone

Comments

@mantoni
Copy link
Contributor

mantoni commented Jun 24, 2015

Reproduce:

$ git clone https://github.com/mantoni/hub.js.git
$ npm i

Has this in the install tree listing:

...
├── nan@1.8.4  extraneous
...

I don't even know where nan is coming from.

When I then go npm ls it fails with error code 1 and the message:

npm ERR! extraneous: nan@1.8.4 /home/u25749/projects/hub.js/node_modules/nan

@iarna While you're at it 💃 😄

@iarna
Copy link
Contributor

iarna commented Jun 24, 2015

hah, ok, I know already what's going on. nan is a subdep of fsevents– the rollback isn't... rolling back enough.

@iarna iarna added this to the multi-stage install milestone Jun 24, 2015
@iarna iarna added the bug label Jun 24, 2015
@iarna iarna modified the milestones: 3.0.1, 3.0.0 Jun 26, 2015
@lukeapage
Copy link

+1 got caught out by this, its not obvious after doing npm install that you need npm prune before you are allowed npm shrinkwrap - it would be handy if shrinkwrap suggested you checkout the prune command, though I guess that will not be needed in the future.

@iarna iarna modified the milestones: 3.2.0, 3.1.0 Jul 1, 2015
@iarna
Copy link
Contributor

iarna commented Jul 1, 2015

Pushing this out till next week, as this was too big to fit in a 2 day week.

iarna added a commit that referenced this issue Jul 10, 2015
@iarna
Copy link
Contributor

iarna commented Jul 10, 2015

Fixed in v3.1.1

@iarna iarna closed this as completed Jul 10, 2015
@iarna iarna removed the next-patch label Jul 10, 2015
@mantoni
Copy link
Contributor Author

mantoni commented Jul 10, 2015

Unfortunately, I can't confirm this to be fixed. I can still reproduce as before, but now it's moaning about os-shim@0.1.2 being extraneous.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants