Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

node-gyp not executed on npm@3 #8736

Closed
piranna opened this issue Jun 27, 2015 · 4 comments
Closed

node-gyp not executed on npm@3 #8736

piranna opened this issue Jun 27, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@piranna
Copy link

piranna commented Jun 27, 2015

I've downloaded node-canvas using git clone (I'm modifying it), but after upgrading to npm@3 and deleting the build, node_modules and deps folders, when doing npm install the dependencies get installed but node-gyp don't get executed and due to this, node-canvas module don't gets compiled. npm don't show any error nor get any error status code.

@iarna iarna added this to the 3.x milestone Jun 27, 2015
@iarna iarna modified the milestones: 3.0.1, 3.x Jun 27, 2015
@iarna
Copy link
Contributor

iarna commented Jun 27, 2015

Yup, sure looks like a bug. Easy to repro too.

Aand, yeah, we just explicitly weren't running the install lifecycle on the top level module. oops!

@piranna
Copy link
Author

piranna commented Jun 27, 2015

👍

@iarna
Copy link
Contributor

iarna commented Jul 1, 2015

This landed in master as 3cb6ad2 and will be in the 3.1.0 release.

@iarna iarna closed this as completed Jul 1, 2015
@iarna iarna removed the in-progress label Jul 1, 2015
@piranna
Copy link
Author

piranna commented Jul 1, 2015

Thank you :-) Just curious, why not in 3.0.0? It's not still released...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants