Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Don't warn on prefer global for devDependencies #8841

Closed
wants to merge 1 commit into from

Conversation

saper
Copy link
Contributor

@saper saper commented Jul 6, 2015

Windows Powershell assumes the command has failed
whenever something is written to stderr.

Followup-To: #1648
Fixes: #8517

@saper
Copy link
Contributor Author

saper commented Jul 6, 2015

I think that da015ee might have uncovered an issue by nuking the cache, is this correct @othiym23 ?

Windows Powershell assumes the command has failed
whenever something is written to stderr.

Followup-To: npm#1648
Fixes: npm#8517
@othiym23
Copy link
Contributor

othiym23 commented Jul 7, 2015

@saper This looks good, but can you add a test, please? Given that you ultimately identified #8517 as a regression, a test case that makes sure that nothing gets printed to stderr for preferGlobal dependencies and devDependencies ought to do it.

@zkat zkat added this to the 2.x-next milestone Jul 15, 2015
@othiym23 othiym23 modified the milestones: 2.13.2, 2.x-next Jul 21, 2015
@iarna iarna modified the milestones: 2.x-next, 2.13.3 Jul 25, 2015
@zkat
Copy link
Contributor

zkat commented Jul 31, 2015

I worked for a while on writing tests for this, but ran into issues with getting the test to actually fail. The plan is to take care of it next thing tomorrow and definitely get it in with next week's release, but I'm bumping this down the line one more time. Gotta figure out what's up with our test setup.

@zkat zkat modified the milestones: 2.x-next-next, 2.x-next Jul 31, 2015
@zkat zkat self-assigned this Jul 31, 2015
@othiym23 othiym23 modified the milestones: 2.x-next-next, 2.x-next Aug 4, 2015
@othiym23
Copy link
Contributor

othiym23 commented Aug 4, 2015

@zkat found another bug related to this functionality while writing the tests for it, so we're going to need a little more time to address it adequately. Next week's release, this time for sure! :D

@saper
Copy link
Contributor Author

saper commented Aug 8, 2015

I have suspected there is some other issue, since da015ee alone shouldn't be enough to cause the problem...

@zkat zkat modified the milestones: 2.x-next-next, 2.x-next Aug 14, 2015
@othiym23 othiym23 modified the milestones: 2.x-next-next, 2.x-next Aug 17, 2015
@othiym23
Copy link
Contributor

@zkat is out for most of this week, and she has a branch with some of the work done for fixing this, so it's getting bumped to the next next release one more time. ;)

@iarna iarna modified the milestones: 3.x-next, 2.x-next-next Aug 17, 2015
@iarna iarna removed this from the 3.x-next milestone Aug 17, 2015
@saper
Copy link
Contributor Author

saper commented Aug 17, 2015

Ah the benefits of distributed version control ...

/me hides :)

@zkat
Copy link
Contributor

zkat commented Aug 26, 2015

Thanks, @saper! I'm moving discussion + review to #9409 cause I wrote a bunch of tests and added some bugfixes over this. :) I'm closing this PR for now.

@zkat zkat closed this Aug 26, 2015
zkat pushed a commit that referenced this pull request Aug 26, 2015
othiym23 pushed a commit that referenced this pull request Aug 28, 2015
@othiym23
Copy link
Contributor

This appears to have come undone in npm@3, so I'm going to reopen this so that @iarna and / or @zkat can take a look at it (and I can re-close an issue that was originally opened in 2011). I've noticed this behavior too, and am not sure exactly what's up.

@othiym23
Copy link
Contributor

Whoops, not going to reopen the PR, will reopen #8517 instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants