This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Elminate warnings about missing package.json at top level #9343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -146,7 +146,8 @@ function getLite (data, noname) { | |||
| lite.problems.push('extraneous: ' + getPackageId(data) + ' ' + (data.path || '')) | |||
| } | |||
|
|
|||
| if (data.error && data.path !== path.resolve(npm.globalDir, '..')) { | |||
| if (data.error && data.path !== path.resolve(npm.globalDir, '..') && | |||
| (data.error.code !== 'ENOENT' || noname)) { | |||
There was a problem hiding this comment.
add (or verify exists) a test that DOES trigger an error at the bottom from a top level package. Invalid package.json.
|
Reviewed by me via ScreenHero, with the suggestion of adding a sad path test. 🐑 once that's added. |
iarna
force-pushed
the
iarna/fix-top-level-errors
branch
from
60e44ab
to
6575ac3
Compare
iarna
added a commit
that referenced
this pull request
Aug 21, 2015
| test('ls-top-errors', function (t) { | ||
| common.npm(['ls'], {cwd: pkg}, function (er, code, stdout, stderr) { | ||
| t.ifErr(er, 'install finished successfully') | ||
| t.is(stderr, expected) |
There was a problem hiding this comment.
these would be be less fragile w/ a regex match
iarna
force-pushed
the
iarna/fix-top-level-errors
branch
from
6575ac3
to
a31958e
Compare
iarna
added a commit
that referenced
this pull request
Aug 21, 2015
|
Landed as 02420dc. It's fitting that these trees are getting "elminated"! Thanks, Rebecca! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm@2 didn't emit these and to be honest, it's not that interesting. The test change actually just reverts a previous test change when these warnings were introduced.
This will half fix #9113