Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

doc: replace node-waf with node-gyp in default install script #9584

Closed
wants to merge 1 commit into from
Closed

doc: replace node-waf with node-gyp in default install script #9584

wants to merge 1 commit into from

Conversation

kenany
Copy link
Contributor

@kenany kenany commented Sep 14, 2015

The behavior described here has been inaccurate for a long time. Not only was the wscript bit removed from read-package-json over 2 years ago (npm/read-package-json@bb5f88a), the install script is what is set to the default (now node-gyp rebuild), not preinstall.

Fixes #9583

@kenany
doc: replace node-waf with node-gyp in default install script
926717e 
The behavior described here has been inaccurate for a long time. Not only was
the `wscript` bit removed from `read-package-json` over 2 years ago, the
`install` script is what is set to the default (now `node-gyp rebuild`), not
`preinstall`.
@aredridel aredridel mentioned this pull request Sep 14, 2015
Closed
@othiym23 othiym23 added this to the 2.x-next milestone Sep 14, 2015
zkat pushed a commit that referenced this pull request Sep 17, 2015
@kenany @zkat
docs: fix references to node-waf
1ec15b3 
The behavior described here has been inaccurate for a long time. Not only was
the `wscript` bit removed from `read-package-json` over 2 years ago, the
`install` script is what is set to the default (now `node-gyp rebuild`), not
`preinstall`.

Fixes #9583

PR-URL: #9584
zkat pushed a commit that referenced this pull request Sep 17, 2015
@kenany @zkat
docs: fix references to node-waf
cf1b39f 
The behavior described here has been inaccurate for a long time. Not only was
the `wscript` bit removed from `read-package-json` over 2 years ago, the
`install` script is what is set to the default (now `node-gyp rebuild`), not
`preinstall`.

Fixes #9583

PR-URL: #9584
iarna pushed a commit that referenced this pull request Sep 17, 2015
@kenany @iarna
docs: fix references to node-waf
8b3859a 
The behavior described here has been inaccurate for a long time. Not only was
the `wscript` bit removed from `read-package-json` over 2 years ago, the
`install` script is what is set to the default (now `node-gyp rebuild`), not
`preinstall`.

Fixes #9583

PR-URL: #9584
@zkat
Copy link
Contributor

zkat commented Sep 18, 2015

Hooray! Merged as cf1b39f

Thanksw @kenany!

@zkat zkat closed this Sep 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.14.5
Development

Successfully merging this pull request may close these issues.
3 participants
@kenany @zkat @othiym23