Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Stop telling users to e-mail me #9948

Closed
ForbesLindesay opened this issue Oct 12, 2015 · 9 comments
Closed

Stop telling users to e-mail me #9948

ForbesLindesay opened this issue Oct 12, 2015 · 9 comments

Comments

@ForbesLindesay
Copy link
Contributor

Like the vast majority of package maintainers, my preferred method for receiving bug reports is on GitHub. Apart from anything, most people who go to GitHub realise that someone else has already had their problem and solved it. Unfortunatley npm keeps telling them to email me:

'You can get their info via:',
' npm owner ls ' + er.pkgname,

Could we direct them to the relevant github issues instead?

@stephnr
Copy link

stephnr commented Oct 12, 2015

I dont immediately see how this is even feasible. How would you go about building it?

@aredridel
Copy link
Contributor

Ooh, if there's repository data in the package.json, that could be a lot better!

@kenany
Copy link
Contributor

kenany commented Oct 12, 2015

Something like this?:

diff --git a/lib/utils/error-handler.js b/lib/utils/error-handler.js
index cd61f79..a8364b4 100644
--- a/lib/utils/error-handler.js
+++ b/lib/utils/error-handler.js
@@ -200,8 +200,8 @@ function errorHandler (er) {
         'not with npm itself.',
         'Tell the author that this fails on your system:',
         '    ' + er.script,
-        'You can get their info via:',
-        '    npm owner ls ' + er.pkgname,
+        'You can report this error here:',
+        '    npm bugs ' + er.pkgname,
         'There is likely additional logging output above.'
       ].join('\n')
     )

@stephnr
Copy link

stephnr commented Oct 12, 2015

I like that idea @kenany , and then just make sure to provide a CONTRIBUTING.md file in your project

@shri3k
Copy link

shri3k commented Oct 12, 2015

I really like how Atom handles this. I believe they just check the error msg/status(?) and also checks if it's already been posted in github and allows you to jump to the posted issue. Not sure if it's quite feasible in npm but that would definitely bring down number of tickets in issue tracker too.

@ForbesLindesay
Copy link
Contributor Author

It should be possible for cases where the project is hosted in GitHub (and has the repository field configured correctly).

trodrigues added a commit to trodrigues/npm that referenced this issue Nov 20, 2015
Urge users to open an issue when an error occurs on a package instead of
telling them to contact the author by default.

See npm#9948
@juliangruber
Copy link
Contributor

@trodrigues's change above looks good to me

othiym23 pushed a commit that referenced this issue Nov 25, 2015
Urge users to open an issue when an error occurs on a package instead of
telling them to contact the author by default.

Fixes: #9948
Credit: @trodrigues
Reviewed-By: @othiym23
PR-URL: #10496
@othiym23
Copy link
Contributor

This is fixed in npm@3 by b25efc8, which somebody will need to backport to npm@2 if they want it there. Thanks to @trodrigues for the fix!

@trodrigues
Copy link
Contributor

Also added it for npm@2 at #10628

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants