This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
The great gently rm refactor #10270
Closed
The great gently rm refactor #10270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
iarna/gently-rm-refactor
branch
4 times, most recently
from
ed627e5
to
60da484
Compare
iarna
force-pushed
the
iarna/gently-rm-refactor
branch
3 times, most recently
from
bb752cc
to
14f4d92
Compare
iarna
force-pushed
the
iarna/gently-rm-refactor
branch
from
14f4d92
to
15598b5
Compare
|
This landed in 3.4.1 |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9980
This was done to try (again) to make gently-rm easier to reason about. Plus fix the bug where globally linked modules couldn't be removed.
Some squashing is probably ultimately in order.
The final, refactored form of the module with full context is here:
https://github.com/npm/npm/blob/60da484/lib/utils/gently-rm.js
And the test is here:
https://github.com/npm/npm/blob/60da484/test/tap/gently-rm-linked-module.js