This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Remove nock and get tests running green in 2.x #10872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.8 http streams have a bug, where if they're paused with data in their buffers when the socket closes, they call `end` before emptying those buffers, which results in the entire pipeline ending and thus the point that applied backpressure never being able to trigger a `resume`. We work around this by piping into a pass through stream that has unlimited buffering. The pass through stream is from readable-stream and is thus a current streams3 implementation that is free of these bugs even on 0.8.
|
There's some git-related flakiness I'm gonna have to spend time on for this. :( |
zkat
force-pushed
the
zkat/2.x-kill-the-nock
branch
3 times, most recently
from
b6dfcb1
to
750e13e
Compare
|
This is ready for review ^_^ |
Specially on travis -- changing ports prevents that conflict from happening, but we'll need to keep doing it for every test that uses git.
zkat
force-pushed
the
zkat/2.x-kill-the-nock
branch
4 times, most recently
from
93ef8e3
to
fb5cd0f
Compare
zkat
force-pushed
the
zkat/2.x-kill-the-nock
branch
from
fb5cd0f
to
ffa1816
Compare
|
🐑🚑💥 It's worth calling out the bug fix implicit in the changed stream usage in |
|
This was merged to 2.14.16! =) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #10706 to the 2.x branch.