Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

The repo, as its checked in, has npm ls errors: #11129

Closed
wants to merge 4 commits into from
Closed

Conversation

iarna
Copy link
Contributor

@iarna iarna commented Jan 13, 2016

npm ERR! missing: glob@^5.0.3, required by init-package-json@1.9.1
npm ERR! missing: has-unicode@^1.0.0, required by gauge@1.2.2
npm ERR! missing: has-unicode@^1.0.0, required by gauge@1.2.2
npm ERR! missing: has-unicode@^1.0.0, required by gauge@1.2.2
npm ERR! missing: glob@^5.0.3, required by read-package-json@2.0.2

This happened because of the glob and has-unicode major release updates, and went undetected because the actions necessary to run the tests (which check for this sort of thing) resolved the missing modules.

The version published to the registry is also missing these things, however if you're updating from a previous 3.x release, it will fix up the install when you do the update, installing the versions listed above in addition to the bundled deps. If you're upgrading from a 2.x release, it won't, but this won't break anything because the breaking changes in glob & has-unicode don't have negative effects for us, and node doesn't care about version numbers when loading modules.

This PR fixes this problem by updating init-package-json and read-package-json to use the new glob, and updating gauge to use the new has-unicode, and then, since gauge isn't a direct dependency of npm, reinstalling the existing versions of npmlog & node-gyp which were the two top level dependents that used gauge.

@iarna iarna added the bug label Jan 13, 2016
@iarna iarna self-assigned this Jan 13, 2016
@iarna iarna added this to the next milestone Jan 13, 2016
@othiym23
Copy link
Contributor

Rubberstamp 🐑 because the logic sounds good and the diff is too large for anything other than a double-check of package.json.

@iarna
Copy link
Contributor Author

iarna commented Jan 13, 2016

Yeah, the diff is 90% removing duplicate copies of readable stream by weight.

@zkat zkat removed the in-progress label Jan 14, 2016
zkat pushed a commit that referenced this pull request Jan 14, 2016
zkat pushed a commit that referenced this pull request Jan 14, 2016
zkat pushed a commit that referenced this pull request Jan 14, 2016
zkat pushed a commit that referenced this pull request Jan 14, 2016
@iarna
Copy link
Contributor Author

iarna commented Jan 19, 2016

It looks like the thing this is fixing breaks installs from 3.3.12 (#11088 (comment))

@iarna
Copy link
Contributor Author

iarna commented Jan 25, 2016

This was merged to 3.5.5! =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants