This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3k
The repo, as its checked in, has npm ls
errors:
#11129
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubberstamp 🐑 because the logic sounds good and the diff is too large for anything other than a double-check of |
Yeah, the diff is 90% removing duplicate copies of readable stream by weight. |
It looks like the thing this is fixing breaks installs from 3.3.12 (#11088 (comment)) |
This was merged to 3.5.5! =) |
This was referenced Jan 31, 2016
This was referenced Feb 8, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because of the
glob
andhas-unicode
major release updates, and went undetected because the actions necessary to run the tests (which check for this sort of thing) resolved the missing modules.The version published to the registry is also missing these things, however if you're updating from a previous 3.x release, it will fix up the install when you do the update, installing the versions listed above in addition to the bundled deps. If you're upgrading from a 2.x release, it won't, but this won't break anything because the breaking changes in
glob
&has-unicode
don't have negative effects for us, and node doesn't care about version numbers when loading modules.This PR fixes this problem by updating
init-package-json
andread-package-json
to use the new glob, and updatinggauge
to use the newhas-unicode
, and then, sincegauge
isn't a direct dependency of npm, reinstalling the existing versions ofnpmlog
&node-gyp
which were the two top level dependents that usedgauge
.