This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
doc: briefly explain what's included in npm publish
#11188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great tweak, and I think a further sentence or two summarizing what happens when one or both of |
iarna
pushed a commit
that referenced
this pull request
Jan 20, 2016
PR-URL: #11188 Credit: @beaugunderson Reviewed-By: @othiym23
beaugunderson
force-pushed
the
bg-publish-docs
branch
from
1265b0c
to
6c706ca
Compare
|
@othiym23 no prob! (and sorry for making you respond on the weekend!) I added a second sentence as requested. :) |
iarna
pushed a commit
that referenced
this pull request
Jan 21, 2016
PR-URL: #11188 Credit: @beaugunderson Reviewed-By: @othiym23
zkat
pushed a commit
that referenced
this pull request
Jan 21, 2016
PR-URL: #11188 Credit: @beaugunderson
|
This was merged to 3.5.5 & 2.14.16! =) |
This was referenced Jan 31, 2016
This was referenced Feb 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Twitter thread I walk through how after publishing versions from many modules (38) I managed to not know that
npm publishincludes all files that are not explicitly ignored by a local.gitignoreor.npmignore(or disallowed by.gitignorebut allowed by.npmignore), and found that I'd managed to include security credentials (since revoked) in published versions of one of my modules, and junk files in many others. I think it would be great to briefly note what's included in thenpm publishdocumentation itself (my suggested description of the behavior may be too simplistic, but I wanted to have a starting point).