This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Make "JSON" snippets valid JSON #11196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for `package.json` [states](https://docs.npmjs.com/files/package.json) that it "must be actual JSON, not just a JavaScript object literal".
|
This looks good to me |
zkat
pushed a commit
that referenced
this pull request
Jan 28, 2016
Documentation for `package.json` [states](https://docs.npmjs.com/files/package.json) that it "must be actual JSON, not just a JavaScript object literal". PR-URL: #11196 Credit: @s100
iarna
pushed a commit
that referenced
this pull request
Jan 28, 2016
Documentation for `package.json` [states](https://docs.npmjs.com/files/package.json) that it "must be actual JSON, not just a JavaScript object literal". PR-URL: #11196 Credit: @s100 Reviewed-By: @iarna
|
This was merged and included in npm@3.7.0 and npm@2.14.17. Thanks! |
|
This is still not valid JSON, the versions field in lines 47-57 is an array but uses curly object braces instead of angled array brackets. |
|
Well, whoops. |
robludwig
added a commit
to robludwig/npm
that referenced
this pull request
Feb 8, 2016
Fix one additional invalid JSON error in original patch.
zkat
pushed a commit
that referenced
this pull request
Mar 3, 2016
Followup PR #11196 with valid JSON PR-URL: #11474 Credit: @robludwig Reviewed-By: @iarna
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for
package.jsonstates that it "must be actual JSON, not just a JavaScript object literal".