Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

lifecycle: prefer current node in run-script #11626

Closed
wants to merge 1 commit into from
Closed

Conversation

narqo
Copy link

@narqo narqo commented Feb 21, 2016

This is a backport of #11204 by @segrey to 2.x branch which I believe was lost.

Fixes: #11175
Fixes: #9253

As mentioned in #11204 (comment) current behaviour of npm@latest-2x is really annoying in cases where one can't have nodejs + npm installed globally.

For example our internal build farms have different nodejs versions installed to /opt/nodejs/<ver>, so we run npm with /opt/nodejs/<N>/bin/node /opt/nodejs/<N>/bin/npm from our build scripts. Everything works fine for projects that run nodejs-0.10 or node-5 that have npm@1x and npm@3x accordingly and which don't have the bug. But for projects that use nodejs-4 builds might fail if one uses an npm module that needs #!/usr/bin/env node to run.

@zkat zkat added merge-to-lts and removed review labels Feb 24, 2016
@zkat zkat added this to the next milestone Feb 24, 2016
zkat pushed a commit that referenced this pull request Feb 24, 2016
@iarna
Copy link
Contributor

iarna commented Feb 26, 2016

Release in 2.14.21! =)

@iarna iarna closed this Feb 26, 2016
@narqo narqo deleted the 2.x branch February 26, 2016 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants