This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
deps: Move shrinkwrap extraneous check suppression to is-extraneous #15086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
force-pushed
the
release-next
branch
4 times, most recently
from
e1c7ae8
to
04d7c2f
Compare
iarna
force-pushed
the
release-next
branch
7 times, most recently
from
20e7365
to
ff1f0bb
Compare
zkat
force-pushed
the
release-next
branch
2 times, most recently
from
692ff0e
to
892f531
Compare
iarna
force-pushed
the
release-next
branch
5 times, most recently
from
6465f26
to
d841f73
Compare
If your `npm-shrinkwrap.json` contains modules not found in your `package.json` we don't complain about them at install time. We WILL complain about them at `npm ls` time. And we WILL complain if you try to make changes to your shrinkwrap though.
iarna
force-pushed
the
iarna/fix-shrinkwrap-binding
branch
from
2c969d6
to
0340271
Compare
zkat
force-pushed
the
release-next
branch
3 times, most recently
from
6f1b69a
to
2ae141b
Compare
zkat
force-pushed
the
release-next
branch
5 times, most recently
from
96fa08f
to
db0a2f8
Compare
zkat
force-pushed
the
release-next
branch
2 times, most recently
from
ea9e85f
to
2fdc7b7
Compare
|
This is now obsolete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your
npm-shrinkwrap.jsoncontains modules not found in yourpackage.jsonwe don't complain about them at install time.We WILL complain about them at
npm lstime. And we WILL complain if you try to make changes to your shrinkwrap though.This fixes a bug where we were NOT complaining about them at
npm lstime.