This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
install/deps: Computed required package in legacy npm compatible way #17590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
iarna/fix-global-remove
branch
3 times, most recently
from
e093e7a
to
b972c38
Compare
Not having this meant that uninstalls of globals installed by npm@4 or earlier would fail, due to _requested not having the fields we expected.
iarna
force-pushed
the
iarna/fix-global-remove
branch
from
b972c38
to
ac0c0e5
Compare
iarna
commented
Jul 3, 2017
| module.exports.computeVersionSpec = computeVersionSpec | ||
| function computeVersionSpec (tree, child) { | ||
| validate('OO', arguments) | ||
| var requested | ||
| if (child.package._requested) { | ||
| var childReq = child.package._requested | ||
| if (childReq && (isNotEmpty(childReq.saveSpec) || (isNotEmpty(childReq.rawSpec) && isNotEmpty(childReq.fetchSpec)))) { |
There was a problem hiding this comment.
We insist that fetchSpec exist with rawSpec because it indicates modern metadata, where as rawSpec alone does not.
zkat
approved these changes
Jul 4, 2017
zkat
pushed a commit
that referenced
this pull request
Jul 5, 2017
zkat
pushed a commit
that referenced
this pull request
Jul 5, 2017
1 task
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having this meant that uninstalls of globals installed by npm@4 or
earlier would fail, due to _requested not having the fields we expected.