This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
suggested changes
Oct 14, 2017
|
|
||
| token.completion = function (opts, cb) { | ||
| var argv = opts.conf.argv.remain | ||
|
|
||
| switch (argv[2]) { | ||
| case 'list': | ||
| case 'delete': | ||
| case 'revoke': |
There was a problem hiding this comment.
I think you should accept both here. This would be a breaking change otherwise, and I think it's fine to have delete as an alias.
There was a problem hiding this comment.
oh oops, I didn't mean to ditch it entirely!
There was a problem hiding this comment.
ah, this is tab completion. I'm ok with not tab completing delete.
zkat
approved these changes
Oct 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus we rename
token deletetotoken revoke.