This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

config: only create config dir before write #20212

Closed

buddydvd wants to merge 1 commit into npm:latest from buddydvd:fix_globalconfig_mkdirp

Contributor

buddydvd commented Mar 31, 2018

This change fixes the bug that creates unnecessary ./etc folder when calling npm with the --prefix flag.

See: #7249 (comment)


          config: only create config dir before write

b1a1ea6

This change fixes the bug that creates
unnecessary ./etc folder when calling npm
with the --prefix flag.

buddydvd requested a review from a team as a code owner

March 31, 2018 01:36

Contributor Author

buddydvd commented Apr 3, 2018 •

edited

PR #7249 (meant to fix #7233) introduced a regression that causes creation of extraneous etc folders when calling npm with the --prefix flag. The effect of the regression is documented in #7249 (closed), #11486 (closed), #11802 (closed), #17322.

This PR fixes the issue by reverting #7249 (while retaining the associated tests) and implementing the suggested fix as described here: #7249 (comment).

The essence of the fix is to only create the possibly missing etc folder just before npm is ready write to the global config file located at $prefix/etc/npmrc.

iarna approved these changes

View reviewed changes

iarna pushed a commit that referenced this pull request


          config: only create config dir before write

This change fixes the bug that creates
unnecessary ./etc folder when calling npm
with the --prefix flag.

PR-URL: #20212
Credit: @buddydvd
Reviewed-By: @iarna
Fixes: #17322

iarna pushed a commit that referenced this pull request


          config: only create config dir before write

16d739b

This change fixes the bug that creates
unnecessary ./etc folder when calling npm
with the --prefix flag.

PR-URL: #20212
Credit: @buddydvd
Reviewed-By: @iarna
Fixes: #17322

iarna pushed a commit that referenced this pull request


          config: only create config dir before write

0e98102

This change fixes the bug that creates
unnecessary ./etc folder when calling npm
with the --prefix flag.

PR-URL: #20212
Credit: @buddydvd
Reviewed-By: @iarna
Fixes: #17322

iarna pushed a commit that referenced this pull request


          config: only create config dir before write

546f55b

This change fixes the bug that creates
unnecessary ./etc folder when calling npm
with the --prefix flag.

PR-URL: #20212
Credit: @buddydvd
Reviewed-By: @iarna
Fixes: #17322

iarna pushed a commit that referenced this pull request


          config: only create config dir before write

f8ec520

This change fixes the bug that creates
unnecessary ./etc folder when calling npm
with the --prefix flag.

PR-URL: #20212
Credit: @buddydvd
Reviewed-By: @iarna
Fixes: #17322

iarna pushed a commit that referenced this pull request


          config: only create config dir before write

11890c9

This change fixes the bug that creates
unnecessary ./etc folder when calling npm
with the --prefix flag.

PR-URL: #20212
Credit: @buddydvd
Reviewed-By: @iarna
Fixes: #17322

iarna pushed a commit that referenced this pull request


          config: only create config dir before write

ced2925

This change fixes the bug that creates
unnecessary ./etc folder when calling npm
with the --prefix flag.

PR-URL: #20212
Credit: @buddydvd
Reviewed-By: @iarna
Fixes: #17322

Contributor

zkat commented Apr 18, 2018

This was already merged and is part of npm@6. Cheers!

zkat closed this

buddydvd deleted the fix_globalconfig_mkdirp branch

April 18, 2018 20:58

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.