Patch bundle all dependencies #2395

Closed
wants to merge 2 commits into
from

Projects

None yet

5 participants

@grncdr

These are the changes required in npm for npm/fstream-npm#1 to be usable.

@isaacs
npm member
@badunk

+1, I would like this as well for npm pack. Its nice to be able to deploy an app with all its dependencies in a sandboxed environment.

Listing the dependencies twice can cause unnecessary mistakes, especially in the case where npm install --save dep is used

@timoxley
npm member

@grncdr bump RE #2395 (comment)

Any update on this?

@grncdr

oh hey, I don't think I ever saw that comment. FWIW I don't actually have any interest in pushing this patch forwards as I adjusted my workflows to not need it long ago. @badunk feel free to grab those diffs and submit a new PR to read-package-json. Also, the pull request for fstream-npm referenced by this one is still open and would need to be merged for this to make any sense. (npm/fstream-npm#1)

@grncdr grncdr closed this Jan 8, 2014
@rlidwka

What about this syntax?:

bundleDependencies: [
  '*',
  '!ronn',
  '!tap',
  '!npm-registry-mock',
]

Where each subsequent line overrides previous one, and "!" negates it's effect?..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment