Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Multiple registry support (re: #1401) #3093

Closed
wants to merge 6 commits into from

Conversation

cianclarke
Copy link

This is my attempt at #1401, allowing whitespace separated registries to be specified in NPM Client. Still to be done from the numbered list in #1401 is 3), 5), 6), 7) - I'm not sure what 4) means (~/.npm/ is cache folder, right? So should it support caching from both registries?)

This pull request I think solves the main issue I've been having, which is there's no way to have a private instance of the registry which just contains private dependencies and doesn't replicate the full registry.npmjs.org. This allows there to be a 'fallback registry'

Review, comments, etc welcome!

@@ -129,11 +135,17 @@ function set (key, val, cb) {
}

function get (key, cb) {
debugger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, please.

@isaacs
Copy link
Contributor

isaacs commented Jan 25, 2013

Before a pull request to npm can be accepted, you should first update https://github.com/isaacs/npmconf and https://github.com/isaacs/npm-registry-client. The changes to npm itself should be virtually nothing.

Closing for now. Please do pursue this in those other repos, though.

@isaacs isaacs closed this Jan 25, 2013
@domenic
Copy link
Contributor

domenic commented Jan 28, 2013

Oooh, this is exciting. /cc @indexzero

@indexzero
Copy link
Contributor

+1 hopefully this lands in the other repos @isaacs talked about.

@cianclarke
Copy link
Author

Sorry guys - I won't be progressing this further for the time being. Without the further info discussed in #1401 I'm just stabbing in the dark.
-I'm still wondering if there's merit in NPM having multiple instances of an npm-registry-client, each with their own auth, associated couch token, rather than having npm-registry-client look after it's own array of registries, but can be implemented either way..
-Agree npmconf should be updated to have a type for registry which supports multiple, but had difficulty when I went down this avenue..

@isaacs
Copy link
Contributor

isaacs commented Feb 8, 2013

@piscisaureus is working on this, a little bird told me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants