This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
cache.js: preparation for git module (factor out getCacheStat) #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: @isaacs already got publish rights for the module, will start a transfer if we merge this in |
| , fs = require("fs") | ||
| , fixtures = path.join(__dirname, "fixtures") | ||
|
|
||
| var npm = { cache: path.join(fixtures, "mycache") } |
There was a problem hiding this comment.
If all you use from the npm object is the cache property, perhaps this module should just accept a cache value?
There was a problem hiding this comment.
You are absolutely right. Missed the forest for the trees :)
This is one of the first steps to factor out the git part of `cache.js` into a separate module which can be tested separately.
|
fixed! :) |
|
Side-note: #4159 discusses mainly caching http agents, not how the git part should work. I'm planning to integrate the git module into |
|
Well, I guess @othiym23's recent cache refactor supersedes this... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the first steps to factor out the git part of
cache.jsinto a separate module which can be tested separately.