Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Make toNerfDart ignore query, search, hash #6514

Closed
wants to merge 1 commit into from

Conversation

indexzero
Copy link
Contributor

@othiym23 corresponding fix for npm/npm-registry-client#74, and not necessarily mutually exclusive. The toNerfDart implementation is duplicated across npm/npm and npm/npm-registry-client and has the same bug.

@isaacs
Copy link
Contributor

isaacs commented Oct 19, 2014

Seems like this is a good candidate for being a standalone module.

@indexzero
Copy link
Contributor Author

@isaacs happy to make one if that's the preferred solution, but it has been 10 days since the original PR npm/npm-registry-client#73 and this is a real blocker for a number of folks. We'd all appreciate it if this got some attention.

@indexzero indexzero mentioned this pull request Oct 22, 2014
@indexzero
Copy link
Contributor Author

Closing in favor of #6538 where nerf-gun standalone module is used.

@indexzero indexzero closed this Oct 22, 2014
@othiym23 othiym23 removed the review label Oct 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants