Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

only specify npm.prefix as gentlyRm base when it is inside folder path #7180

Closed
wants to merge 1 commit into from

Conversation

phated
Copy link
Contributor

@phated phated commented Jan 21, 2015

Possible fix for #6850

Thanks @othiym23 for the guidance.

@othiym23 othiym23 added the bug label Jan 21, 2015
@othiym23
Copy link
Contributor

I need to review this one pretty carefully, and maybe write a couple more tests, but I'll try to land this for this week's release. @iarna, can you double-check @phated's logic here and make sure it makes sense to pass in the unbuilt folder like this?

@othiym23
Copy link
Contributor

Landed as 29a6ef3 (a semicolon snuck in!). I still need to write a bunch of unhappy-path tests around this, but I looked it over and I think this is probably not a lot more dangerous than what we had before (and is a lot less dangerous than what we had before I rewrote gently-rm.js in the first place.

Thanks, @phated!

@othiym23 othiym23 closed this Jan 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants