This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Adds function call to gitEnv in checkGitDir #7486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In checkGitDir when executing `git config --get remote.origin.url` the gitEnv function is passed to git.whichAndExec instead of the result of that function.
|
Aaaaaaa! Thank you for spotting this! I really wish there were tests that prevented this from going unnoticied, but the existing git tests were hard enough to write as it is. As such, I'm not going to insist on a test for this. |
|
Rebased and landed as c8258f3. Thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In checkGitDir when executing
git config --get remote.origin.urlthe gitEnv function is passed to git.whichAndExec instead of the result of that function.The typo was introduced with this commit: 00ecb61#diff-949ff1cc9c69a73d643a809580064773R84