Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

report: add new command #7611

Closed
wants to merge 26 commits into from
Closed

report: add new command #7611

wants to merge 26 commits into from

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Mar 12, 2015

Hi, I added report command for fixing #5214. That proposal might make support useful, people become needn't bring manually a npm-debug.log to the issue description in GitHub.

Well, I'd like to use gist but I think it might makes npm a little bit complex so I've built in this way.
See also: #5214 (comment)

Thanks.

@rlidwka
Copy link
Contributor

rlidwka commented Mar 12, 2015

Well, I'd like to use gist but I think it might makes npm a little bit complex so I've built in this way.

Just post it to some kind of pastebin with 1 month expiration time imho.

@othiym23
Copy link
Contributor

I like this! I do think it's going to take a little effort to land this, but now is probably as good a time as ever to get this moving along. This is an actual honest-to-gosh feature in npm, and as such needs a little extra effort to get right:

It would be fantastic to actually implement #5214, as we've been wanting this for nearly a year, so I'm willing to budget some of npm's time towards making sure this keeps moving forward. Thanks, @watilde!

@smikes
Copy link
Contributor

smikes commented Mar 14, 2015

What happens on issues/new if the user is not logged in to github?

@watilde
Copy link
Contributor Author

watilde commented Mar 14, 2015

Sorry for my late reply,

@rlidwka Thanks for your information! I'll use it a little, but maybe I can't decide to include that to this patch in this time..

@othiym23 Sounds great! I'm going to added a document in doc/api | doc/cli to this patch.

@smikes Thanks for your comment, Redirect to this URL, after logged in report process will go well.

@othiym23
Copy link
Contributor

1 down, 3 to go! Thanks for the docs!

By the way, I think this will probably be something that lands after the release of npm@3, as I'm trying to hold off on landing any more significantly-sized features to the npm@2 code base that aren't directly related to support for the new npm registry infrastructure. So you may want to rebase against multi-stage at some point, and also be prepared to wait a little while for this one to get merged. But getting this in will be great!

@watilde
Copy link
Contributor Author

watilde commented Mar 17, 2015

@othiym23 I agreed to be something that lands after the release of npm@3. I'll git rebase multi-stage and wait as a next-major! I hope to make it helps npm supports, thanks.

@othiym23
Copy link
Contributor

This has been moved to the npm roadmap, which we're using instead of the confusing next-* labels now. Also, because this PR is pretty old and would need some work to land against master, I'm going to close this particular PR.

@watilde -san, once npm@3 has landed / is the default version of npm, would you be interested in working with us to get a new version of this put together that includes #7611 and #6350? npm, Inc. now has an actual (and fantastic) support team to help out with the issues on this repo, but it would be great if we could channel front-line support into a more useful place.

body = "npm-debug.log:\n"
body += "```\n"
body += fs.readFileSync(npmDebugLog)
body += "```\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it should ask user for input like:
What were you trying to do?
Any other comments?
Stuff like that. Also, maybe write to a file and then let the user edit it before sending it off?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants