This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Fix linking of scoped modules #8975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
iarna/fix-link-scoped
branch
2 times, most recently
from
8eb88c8
to
d8ec61b
Compare
iarna
force-pushed
the
iarna/fix-link-scoped
branch
from
d8ec61b
to
fdb360f
Compare
| @@ -50,6 +50,14 @@ function link (args, cb) { | |||
| linkPkg(npm.prefix, cb) | |||
| } | |||
|
|
|||
| function parentFolder (id, folder) { | |||
There was a problem hiding this comment.
Maybe I'm overly paranoid, but I'd also like a check that guarantees there's a / in the name before adding a second parent directory into the mix. Is that too paranoid?
There was a problem hiding this comment.
The worst case scenario here if a / is missing is that it refuses to link the module. And given that it's invalid to start a module name with '@' and not have it be a scoped module, I'm not concerned about that happening.
There was a problem hiding this comment.
You have more faith in software to not do the most perverse possible thing than I do, but I defer to your judgment.
|
Question / paranoia aside, LGTM. 🐑 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking scoped modules was failing due to a check intended to see if the module was installed in the global directory. This did the classic
path.resolve(blah, '..')which always, ALWAYS fails for scoped modules. Alas. Adds a test for this scenario too.